Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Terrain Lockups in requestTileGeometry due to Promise Handling Inconsistencies #11630

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Fix Terrain Lockups in requestTileGeometry due to Promise Handling Inconsistencies #11630

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40cd32d
handle undefined/deferred return
Nov 14, 2023
b7280b2
following contribution guidelines
Nov 14, 2023
4737ed2
change log
Nov 14, 2023
fc60653
implicit promise handling
marcejohnson Nov 21, 2023
67e4a4f
Merge branch 'main' into prevent-infinite-loop-requestTileGeometry
marcejohnson Nov 21, 2023
6710e18
prettier change
Nov 21, 2023
77d7339
Merge branch 'main' into prevent-infinite-loop-requestTileGeometry
marcejohnson Nov 28, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prettier change
  • Loading branch information
Marc E. Johnson committed Nov 21, 2023
commit 6710e181cf4b371067b14ac3123c9fd6463e1bd0
2 changes: 1 addition & 1 deletion packages/engine/Source/Core/CesiumTerrainProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ CesiumTerrainProvider.prototype.requestTileGeometry = function (
// Try again when availability data is ready– Otherwise the tile will be marked as failed and never re-requested
return availabilityPromise.then(() => {
// handle promise or undefined return
return new Promise(resolve=> {
return new Promise((resolve) => {
// defer execution to the next event loop
setTimeout(() => {
const promise = this.requestTileGeometry(x, y, level, request);
Expand Down