Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Building Scene Layer (BSL) OGC I3S standard #11678

Merged
merged 33 commits into from
Feb 28, 2024
Merged

Add support for Building Scene Layer (BSL) OGC I3S standard #11678

merged 33 commits into from
Feb 28, 2024

Commits on Dec 5, 2023

  1. - Added support for conversion from sRGB color space profile to linea… 

    …r color space profile

Purpose: Helper function to fix color saturation
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    808fcaa View commit details
    Browse the repository at this point in the history

  2. Added Support for BSL structure, BSL statistics, generic feature attr… 

    …ibute driven filter.

Added new initialization option: enableFeatureFiltering, adjustMaterialAlphaMode, applySymbology and calculateNormals
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    0b9869b View commit details
    Browse the repository at this point in the history

  3. I3S Building Scene Layer Sandcastle app

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d612e7b View commit details
    Browse the repository at this point in the history

  4. I3S BSL app icon

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a4da846 View commit details
    Browse the repository at this point in the history

  5. Added support for conversion from sRGB color space profile to linear … 

    …color space profile
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f469a21 View commit details
    Browse the repository at this point in the history

  6. added additional payload options

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4f92b4a View commit details
    Browse the repository at this point in the history

  7. - Added support for binary attribute data with values stored in objec… 

    …tIds property

- Added validation for actual and expected binary buffer size
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a2066b0 View commit details
    Browse the repository at this point in the history

  8. - Added support for 3D objects transparency 

    - Fixed material color saturation by converting sRGB colors in I3S data to linear color space profile
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    562d6e5 View commit details
    Browse the repository at this point in the history

  9. - Added support for BSL hierarchy of layers 

    - Added support for the generic feature attribute driven filter
- Added support for I3S symbology
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    89f6dbe View commit details
    Browse the repository at this point in the history

  10. - Added support for the generic feature attribute driven filter 

    - Added support for I3S symbology
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    394f823 View commit details
    Browse the repository at this point in the history

  11. Added support for BSL structure per the OGC I3S standard

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1394e4a View commit details
    Browse the repository at this point in the history

  12. - Added support for symbolization defined in I3S Layer data

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5a34b60 View commit details
    Browse the repository at this point in the history

  13. Added support for EXT_mesh_features and EXT_structural_metadata glTF … 

    …extensions with the feature index data

Added support for 3D objects transparency
Added support  for CESIUM_primitive_outline glTF extensions with the generated outlines indices
Added support for flat normals calculation if vertex normals are stripped out from I3S geometry
Fixed vertex color saturation by converting sRGB colors in I3S geometry to linear color space profile
    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1054536 View commit details
    Browse the repository at this point in the history

  14. Added bsl layer tests

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e1d55f7 View commit details
    Browse the repository at this point in the history

  15. Added I3S BSL ViewModel tests

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    04f3c51 View commit details
    Browse the repository at this point in the history

  16. Added I3S BSL explorer

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3e75b94 View commit details
    Browse the repository at this point in the history

  17. Added I3S Explorer tests

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    969ac49 View commit details
    Browse the repository at this point in the history

  18. Added I3S BSL Explorer layer widget

    @Tamrat-B
    Tamrat-B committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b4b23a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Merge branch 'CesiumGS:main' into feature/i3s_bsl_support

    @Tamrat-B
    Tamrat-B committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e03286b View commit details
    Browse the repository at this point in the history

  2. updates based on review feedback

    @Tamrat-B
    Tamrat-B committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    21b2f4f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Added I3S support PR to additions

    @Tamrat-B
    Tamrat-B committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    efc7db5 View commit details
    Browse the repository at this point in the history

  2. removed non necessary options

    @Tamrat-B
    Tamrat-B committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    03a9125 View commit details
    Browse the repository at this point in the history

  3. check before updating visibility

    @Tamrat-B
    Tamrat-B committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    17784df View commit details
    Browse the repository at this point in the history

  4. additional specs changes

    @Tamrat-B
    Tamrat-B committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c815c03 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/i3s_bsl_support

    @Tamrat-B
    Tamrat-B committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    4bffc64 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'CesiumGS:main' into feature/i3s_bsl_support

    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9f02cf3 View commit details
    Browse the repository at this point in the history

  2. Removed picking result from console output

    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9d6dc59 View commit details
    Browse the repository at this point in the history

  3. Remove console out if geoid transform is not needed

    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c7570c3 View commit details
    Browse the repository at this point in the history

  4. Default to model overview if present

    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    88eae59 View commit details
    Browse the repository at this point in the history

  5. update tests to account for model views

    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1aefdc9 View commit details
    Browse the repository at this point in the history

  6. Added I3S Building Scene Layer support to March 1 release

    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    cf8d1da View commit details
    Browse the repository at this point in the history

  7. Handling edge case use cases where there is no Full Model and/or Over… 

    …view
    @Tamrat-B
    Tamrat-B committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    96aca3e View commit details
    Browse the repository at this point in the history

  8. Rename BSL -> BuildingSceneLayer

    @ggetz
    ggetz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a3ea292 View commit details
    Browse the repository at this point in the history