Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating Camera.changed to account for changes in roll #11844

Merged
merged 4 commits into from
Feb 23, 2024
Merged

updating Camera.changed to account for changes in roll #11844

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a76d1a7
updating Camera.changed to account for changes in roll
malaretv Feb 21, 2024
8443490
Update CHANGES.md
malaretv Feb 21, 2024
598f942
remove early return
malaretv Feb 21, 2024
ca88d4e
explicitly intialize _changedRoll in camera constructor
malaretv Feb 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove early return
  • Loading branch information
@malaretv
malaretv committed Feb 21, 2024
commit 598f9429f6f6582fe2c17e9e97c98ef3f793022e
1 change: 0 additions & 1 deletion packages/engine/Source/Scene/Camera.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ Camera.prototype._updateCameraChanged = function () {
camera._changed.raiseEvent(
Math.max(rollChangedPercentage, headingChangedPercentage)
);
return;
}
if (camera._mode === SceneMode.SCENE2D) {
if (!defined(camera._changedFrustum)) {
Expand Down
Loading