Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft for fixing disappearing I3DM models #12105

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Draft for fixing disappearing I3DM models #12105

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d381c1d
Draft for fixing disappearing I3DM
javagl Aug 1, 2024
21ef2d7
Debug output for review and tests
javagl Aug 1, 2024
8aa67fd
Do not modify the render resources
javagl Aug 1, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Debug output for review and tests
  • Loading branch information
@javagl
javagl committed Aug 1, 2024
commit 21ef2d765f6dd8a6399f31f8baa9a0592be29065
23 changes: 22 additions & 1 deletion packages/engine/Source/Scene/Model/buildDrawCommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,27 @@ function buildDrawCommand(primitiveRenderResources, frameState) {
);
}

console.log("buildDrawCommand");
console.log(" positionMin", primitiveRenderResources.positionMin);
console.log(" positionMax", primitiveRenderResources.positionMax);
console.log(
" instancingTranslationMin ",
primitiveRenderResources.runtimeNode.instancingTranslationMin
);
console.log(
" instancingTranslationMax ",
primitiveRenderResources.runtimeNode.instancingTranslationMax
);
console.log(
" node scale ",
primitiveRenderResources.runtimeNode.computedTransform[0]
);
console.log(
" instances transformInWorldSpace ",
primitiveRenderResources.runtimeNode.node?.instances?.transformInWorldSpace
);
console.log(" radius", primitiveRenderResources.boundingSphere.radius);

// Initialize render state with default values
let renderState = clone(
RenderState.fromCache(primitiveRenderResources.renderStateOptions),
Expand Down Expand Up @@ -117,7 +138,7 @@ function buildDrawCommand(primitiveRenderResources, frameState) {
pickId: pickId,
instanceCount: primitiveRenderResources.instanceCount,
primitiveType: primitiveRenderResources.primitiveType,
debugShowBoundingVolume: model.debugShowBoundingVolume,
debugShowBoundingVolume: true, //model.debugShowBoundingVolume,
castShadows: castShadows,
receiveShadows: receiveShadows,
});
Expand Down