Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional OrientedBoundingBox functionality #12178

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Additional OrientedBoundingBox functionality #12178

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d44d57b
Added fromMinMax and transform for OBB
javagl Aug 29, 2024
f60e7e2
Add intersection test for OBB
javagl Aug 31, 2024
1ef07be
Remove fit from specs (and fix copy-and-paste error)
javagl Sep 1, 2024
7466d6d
Fix typo in comment
javagl Sep 1, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo in comment
  • Loading branch information
@javagl
javagl committed Sep 1, 2024
commit 7466d6ddfd56f1c11577222a5abda6017c91095f
2 changes: 1 addition & 1 deletion packages/engine/Source/Core/OrientedBoundingBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ const scratchIntervalB = new Interval();
* axis are non-overlapping.
*
* This method will return `true` when the points are "touching" -
* i.e. it returns `true` if and only if they are really separated.
* i.e. it returns `false` if and only if they are really separated.
*
* The axis will usually have unit length (but does not need to).
* If the given axis has a length that is epsilon-equal to zero,
Expand Down