-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera flyto fix #9498
Camera flyto fix #9498
Conversation
Thanks for the pull request @kalosma!
Reviewers, don't forget to make sure that:
|
@ebogo1 thanks for looking into this. I added the new test and updated CHANGES.md. Please let me know if anything else is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that these changes work in Sandcastle and that the build will pass on CesiumJS master. Just a couple small tweaks and this should be good to go!
Co-authored-by: Eli Bogomolny <31491650+ebogo1@users.noreply.github.com>
Thanks @ebogo1! All changes should be in now. Let me know if I need to change anything else |
Looks good, thanks @kalosma! |
Fix for bug #9497
The camera flyTo is not properly working when using a generic ellipsoid, for example a lunar one (ellipsoid radius: 1737400).
The final cartographic camera position is the one in WGS84 ellipsoid.
The problem is visible in the following sandcastle example.
The flyTo destination position is set to
(1737500, 0, 0)
The final camera position when the flyTo finishes is
(6378237, 0, 0)
Sandcastle example:
sandcastle