Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for last box in file being a child box #44

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Account for last box in file being a child box #44

merged 1 commit into from
Feb 16, 2023

Conversation

cchanley2003
Copy link
Contributor

The current calculations seems to assume that the last box is a top level box. Believe we don't need the calculation at all. If this is the last box, consume the remaining buffer.

From ISO/IEC 14496-12

size is an integer that specifies the number of bytes in this box, including all its fields and contained
boxes; if size is 1 then the actual size is in the field largesize; if size is 0, then this box is the last
one in the file, and its contents extend to the end of the file
@cchanley2003 cchanley2003 mentioned this pull request Oct 29, 2021
Closed
5 tasks
@bbert bbert merged commit 49c05a3 into Dash-Industry-Forum:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@cchanley2003 @bbert