Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React-Live did not catch a runtime error (not caught in the transpile phase).
We can't catch all errors (like event handlers) but we can catch
useEffect
's cleanup functions.Fixes # (issue)
2024-08-15.18-14-26.mp4
The above video demonstrates, not a cleanup function not causing crash.
Worth noting, cleanup function runs one cycle "behind", therefore even if we correct the code the previous code with error still shows up.
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)