Do not report controller error on device disconnected #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A device disconnection (when the adb connection is closed) makes the read() on the "receiver" socket fail. Since commit 063a833, this is reported as an error. As a consequence, scrcpy fails with: ERROR: Controller error instead of: WARN: Device disconnected To fix the issue, report a device disconnection in that case. PR #5044 <#5044>
rom1v
force-pushed
the
device_disconnected
branch
from
08bf280
to
b419eef
Compare
FreedomBen
pushed a commit
to FreedomBen/scrcpy
that referenced
this pull request
Aug 2, 2024
A device disconnection (when the adb connection is closed) makes the read() on the "receiver" socket fail. Since commit 063a833, this is reported as an error. As a consequence, scrcpy fails with: ERROR: Controller error instead of: WARN: Device disconnected To fix the issue, report a device disconnection in that case. PR Genymobile#5044 <Genymobile#5044>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A device disconnection (when the adb connection is closed) makes the
read()on the "receiver" socket fail.Since commit 063a833, this is reported as an error. As a consequence, scrcpy fails with:
instead of:
To fix the issue, report a device disconnection in that case.