Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explain_manifest): bump lief and return matched groups #13639

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Sep 9, 2024

Summary

Bump lief (0.12.x no longer builds on ubuntu 24.04 host) and return matched groups

Issue reference

From #13626

KAG-4672

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 9, 2024
@fffonion fffonion force-pushed the explain-match-group branch 4 times, most recently from 10f326e to ce94d62 Compare September 10, 2024 14:00
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Sep 10, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 16, 2024
@fffonion fffonion merged commit 8210e88 into master Sep 29, 2024
29 checks passed
@fffonion fffonion deleted the explain-match-group branch September 29, 2024 06:30
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13639-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13639-to-master-to-upstream
git checkout -b cherry-pick-13639-to-master-to-upstream
ancref=$(git merge-base c937edc625351bdfab810253e1adf44c3856ad7f 51497f870a798a3440bdc694725854c72df76efb)
git cherry-pick -x $ancref..51497f870a798a3440bdc694725854c72df76efb
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 29, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/M skip-changelog
5 participants