Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): add a new feature to support multiple domains for KM GUI #13664

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Sep 13, 2024

Summary

  1. By default, set the origin retrieved from the request header or '*'.
  2. If the admin_gui_url has more than one domain, the origin from the request header must match one of the admin_gui_url. Otherwise, It can't access the Admin API via the Kong Manager.
    For example:
    admin_gui_url=http://example.com,http://km.konghq.com/manager
    These addresses access Kong Manager works well. http://example.com and http://km.konghq.com/manager.
    Others can't.

EE's PR is here: https://github.com/Kong/kong-ee/pull/10260

Checklist

Issue reference

KM-516

Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort. Let's decide the optimal way to implement this feature before going deep into this.

@raoxiaoyan raoxiaoyan marked this pull request as ready for review September 27, 2024 07:40
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 27, 2024
kong.conf.default Outdated Show resolved Hide resolved
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

kong.conf.default Outdated Show resolved Hide resolved
@guanlan guanlan removed the author/community PRs from the open-source community (not Kong Inc) label Oct 10, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 10, 2024
@raoxiaoyan raoxiaoyan removed author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Oct 11, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 11, 2024
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ADD-SP ADD-SP changed the title feat(gui): added a new feature to support multiple domains for gui. Oct 14, 2024
@ADD-SP ADD-SP changed the title feat(gui): add a new feature to support multiple domains for gui Oct 14, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Oct 14, 2024
@ADD-SP ADD-SP merged commit 0b0cbed into master Oct 14, 2024
52 checks passed
@ADD-SP ADD-SP deleted the feat/KM-122 branch October 14, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment