Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for fetching stickers from MPD #20

Merged
merged 3 commits into from
Jan 12, 2013

Conversation

multani
Copy link
Collaborator

@multani multani commented Jan 4, 2013

MPDClient now parses the output of MPD and provide a more convenient way of accessing stickers.

Otherwise, clients have to parse the output by hand, which is not very convenient...

MPDClient now parses the output of MPD and provide a more convenient way
of accessing stickers.
@Mic92
Copy link
Owner

Mic92 commented Jan 5, 2013

I agree with you. This is right and the better way.
But I have to drop the "drop-in replacement" label from my library.
And we have to document this api break.

@multani
Copy link
Collaborator Author

multani commented Jan 5, 2013

Well.

As I see it, the lib is quite stable at the moment, it's up-to-date with the current MPD, and gets most "base" features that it can have (Python 3, extensibility, full command set (even if it doesn't handle everything the best it could, as for the stickers), etc.)
But, this is not yet v1.0, and upstream repository looks as dead as a dry slug smashed by car. So, I would say: assume the fork (drop-in until v0.4.x), and break the API if it's for greater good.

But well, you are the maintainer :)

@Mic92
Copy link
Owner

Mic92 commented Jan 5, 2013

We just need, something like a porting guide, which shows the api difference.
The origin project have some examples, which should be ported too.

@multani
Copy link
Collaborator Author

multani commented Jan 5, 2013

I'll take care of this.

@multani
Copy link
Collaborator Author

multani commented Jan 5, 2013

And hop!
As always, both code and doc are subject to review for improvements!

Mic92 added a commit that referenced this pull request Jan 12, 2013
Better support for fetching stickers from MPD
@Mic92 Mic92 merged commit bcaf8a3 into Mic92:master Jan 12, 2013
@multani multani deleted the better-stickers-support branch January 12, 2013 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants