Improve TableStoreWriteLock 'locked by me' message #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chroniclekevinpowe
force-pushed
the
feature/store-lock-tid
branch
3 times, most recently
from
87818d0
to
52be053
Compare
JerryShea
reviewed
Sep 18, 2024
| while (!lock.compareAndSwapValue(UNLOCKED, PID)) { | ||
| currentLockValue = lockGetCurrentLockValue(tlPauser); | ||
| } | ||
|
|
||
| // Set tid explicitly here | ||
| lockedByThread = Thread.currentThread(); |
There was a problem hiding this comment.
Thread.currentThread() can be slow - maybe we need to hide this behind a feature property. Maybe we can even piggy back on one of the existing ones.
There was a problem hiding this comment.
actually, as discussed, lets re-use existing lockedByThread and enable with jvm.resource.tracing a new property
chroniclekevinpowe
force-pushed
the
feature/store-lock-tid
branch
from
98b4296
to
5988b92
Compare
chroniclekevinpowe
force-pushed
the
feature/store-lock-tid
branch
2 times, most recently
from
8c19cbb
to
43f6c53
Compare
JerryShea
reviewed
Sep 23, 2024
src/main/java/net/openhft/chronicle/queue/impl/single/TableStoreWriteLock.java
Show resolved
Hide resolved
chroniclekevinpowe
force-pushed
the
feature/store-lock-tid
branch
from
43f6c53
to
7a82a0f
Compare
JerryShea
reviewed
Sep 23, 2024
| @@ -123,9 +127,10 @@ private String lockHandleTimeoutExCreateWarningMessage(String lockedBy) { | |||
|
|
|||
| @NotNull | |||
| protected String getLockedBy(long value) { | |||
| String threadId = lockedByThread == null ? "unknown - " + STORE_LOCK_THREAD + " not set" : Long.toString(lockedByThread.getId()); | |||
JerryShea
approved these changes
Sep 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread ID stored when lock for queue is acquired, and output when attempt to acquire lock by current process fails.