Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation for not activated language in the file #566

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

reichie020212
Copy link
Member

Why is this change needed?

Need to add a checker if all language is activated.

How was the change implemented?

Added a validation that checks if all language in the uploaded file is activated.

New unit tests

No new unit tests

Unit tests executed by the author

spp_area/tests/test_area_import.py::AreaImportTest

How to test manually

  • Install the module spp_area
  • go to Area -> Area Import

Test 1

  • Upload the file. make sure that the file have a language that is not activated.
  • Click Import button.
  • Check if there is an error message.

Test 2

  • Activate the language.
  • Import again the file.
  • Check if there is no error message anymore.

Related links

#464

@reichie020212 reichie020212 linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (38a3b55) to head (8c8c569).

Additional details and impacted files
@@           Coverage Diff           @@
##             17.0     #566   +/-   ##
=======================================
  Coverage   73.59%   73.59%           
=======================================
  Files         559      559           
  Lines       14056    14056           
  Branches     1792     1792           
=======================================
  Hits        10345    10345           
  Misses       3394     3394           
  Partials      317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants