Debugger: Use safe vtlb read/write methods #11595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0bes
force-pushed
the
debugger-tlb-recursion
branch
from
61bf13a
to
8461616
Compare
|
It's still crashing :/ |
Can you show error and backtrace? |
|
I fixed the recursion, but you're right, the crash is still there. The backtrace is quite odd, it's crashing inside of Qt. I'll have to further investigate. |
I don't have a crash log. My.Movie.mp4 |
F0bes
force-pushed
the
debugger-tlb-recursion
branch
from
8461616
to
a08d8b3
Compare
F0bes
force-pushed
the
debugger-tlb-recursion
branch
from
a08d8b3
to
81b0a57
Compare
F0bes
changed the title
F0bes
force-pushed
the
debugger-tlb-recursion
branch
from
81b0a57
to
a851374
Compare
Mrlinkwii
approved these changes
Sep 26, 2024
kamfretoz
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Instead of using the unsafe vtlb access functions that can cause tlb misses and trigger MMIO handlers I've migrated the debugger to use the safer ones.
Rationale behind Changes
This seems to have fixed the recursion issue when pause-on-tlb-miss is enabled.
It also wasn't great that the debugger can read guest FIFOs and such.
Suggested Testing Steps
Enable pause-on-tlb-miss, open the debugger, and reset a bunch of times and see if PCSX2 crashes.
Test and see if the debugger still works fine.
Fixes #11594