Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data not found error messages. #8295

Merged

Conversation

kevinwheeler
Copy link
Contributor

If the data directory or file is not found, output the exception message. If it was the directory that wasn't found, prompt the user to consider using Globals.DataFolder to make sure they are using the correct data folder if running in a docker container.

Description

Related Issue

N/A

Motivation and Context

I needed the improved error message to figure out why my data directory/files kept not being found. Since I made the changes anyways, I thought I might as well push them.

Requires Documentation Change

No

How Has This Been Tested?

I ran "lean build" and then used this custom image when using the lean cli to run a backtest with the wrong data directory. The error message was properly included.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [ X] Non-functional change (xml comments/documentation/etc)

Checklist:

  • [ X] My code follows the code style of this project.
  • [ X] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
    Not sure how I would test this. The error message isn't returned by the function where it is generated. It gets incorporated into a new object that is created.
  • [ X] All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kevinwheeler! Welcome to Lean ✨

@Martin-Molinero Martin-Molinero merged commit a0055a3 into QuantConnect:master Sep 20, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants