Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tic_tac_toe: Both player are filling choice at different time on… #1412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashvin-parmar
Copy link

…e by one

problem

Previously/Problem : There are 2 player playing but tic_tac_toe game but preferences for choice filling for 'o' and 'x' are filled at same time, which cause a bug in which same 'x' value are filled 2 times.
Which need to be improved and also at one time only one player can fill thier choice, that why i resolve this problem.

solution

Solution: I used conditional statement in which value of 'x' which are used for first player choice applied when (instance_for_loop%2==0) or else part for other player. on each round thier is checking for any player for win the match or draw and in a manner such that once player data is not assigned to other one.

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Both player are filling choice at different time one by one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant