Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial work on h264 chunked mode (decoding before getting full frame) #555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Initial work on h264 chunked mode (decoding before getting full frame) #555

wants to merge 2 commits into from

Conversation

funman
Copy link
Contributor

@funman funman commented Jan 11, 2019

No description provided.

@funman
h264f: clear next_uref of nal offsets
c54714e 
This avoid outputting wrong offsets if the next frame has less NALs
@funman funman changed the title H264 Jan 11, 2019
@funman
avcdec: only store uref when needed
59c5877 
This is needed if several input urefs are needed to output a frame,
for example when settings flags2 to chunks with h264
@cmassiot
Copy link
Collaborator

I think the reason we kepts a copy of the uref as long as possible was that avcodec sometimes requests a buffer with no reason. Are you sure there is no regression with this patch?
@funman
Copy link
Contributor Author

funman commented Jan 18, 2019

We are still keeping a uref, it's just the first of N urefs until a buffer is getting output.
I don't see how a regression is possible as after we set stored uref to NULL the upipe_avcdec_input call is done, and there's gonna be a uref with the next one.
@kierank
Copy link
Contributor

kierank commented Mar 4, 2019

ping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@funman @cmassiot @kierank