audio_merge: Make audio channel mismatch message verbose #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not an error, there are use-cases for this
cmassiot
reviewed
Oct 2, 2019
| @@ -356,7 +356,7 @@ static void upipe_audio_merge_produce_output(struct upipe *upipe, struct upump * | |||
| uint8_t output_channels = 0; | |||
| UBASE_ERROR(upipe, uref_sound_flow_get_channels(upipe_audio_merge->flow_def, &output_channels)); | |||
| if (input_channels != output_channels) | |||
| upipe_err_va(upipe, "total input channels (%"PRIu64") != output flow def (%d), some will be skipped or blanked!", | |||
| upipe_verbose_va(upipe, "total input channels (%"PRIu64") != output flow def (%d), some will be skipped or blanked!", | |||
There was a problem hiding this comment.
Don't you think it would be better to print it once in set_flow_def ?
There was a problem hiding this comment.
Actually the check is wrong to begin with, I think the intention is to make sure the sum(uref_channels) = sum(flow_def_channels)
|
Since I am working on the pipe I took a quick look at this. AFAICS if you do it in set_flow_def for the subpipes it will print one message for each input until the sum equals the output flow_def, then nothing when equal, then again when greater. Maybe it is supposed to check that the input urefs match what the input flow_defs say and print a message when they are different indicating some error. I'm not sure myself so I have just silenced it while I am testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not an error, there are use-cases for this