Use additional headers in the signature payload: #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to use headers in the signature payload during the verification process. For example, a timestamp header can be used to validate if requests have been sent recently and reduce the risk of message replays. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
The range body will not execute if the len of r.Parameter.SignaturePayloadHeaders is 0. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Cover the Evaluate func with additional headers for sha1, sha256, sha512. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Dependencies were old. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use additional headers in the signature payload:
This will allow users to use headers in the signature payload during the verification process. For example, a timestamp header can be used to validate if requests have been sent recently and reduce the risk of message replays.
Fixes: #643