Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix multivariate normal bug #21105

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Fix multivariate normal bug #21105

merged 1 commit into from
Jul 29, 2022

Conversation

hankaj
Copy link
Contributor

@hankaj hankaj commented Jul 22, 2022

Description

This PR fixes problem with mxnet.np.random.multivariate_normal producing unexpected results described in this issue.

In the previous implementation, wrong columns were multiplied.

These are resulting plots
image
@hankaj hankaj requested a review from szha as a code owner July 22, 2022 10:08
@mxnet-bot
Copy link

Hey @hankaj , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, clang, centos-gpu, miscellaneous, sanity, centos-cpu, windows-gpu, website, windows-cpu, unix-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jul 22, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 22, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 22, 2022

@mxnet-bot run ci [centos-gpu, miscellaneous, website, windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, miscellaneous, centos-gpu, windows-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 22, 2022
@bgawrych
Copy link
Contributor

@mxnet-bot run ci [centos-gpu, windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, centos-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 25, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 25, 2022

@mxnet-bot run ci [centos-gpu, windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, centos-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 25, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 26, 2022

@mxnet-bot run ci [windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 26, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 26, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 27, 2022

@mxnet-bot run ci [windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 27, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 27, 2022

@mxnet-bot run ci [windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 27, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 28, 2022

@mxnet-bot run ci [windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 28, 2022
@hankaj
Copy link
Contributor Author

hankaj commented Jul 28, 2022

@mxnet-bot run ci [windows-gpu]
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 28, 2022
@bgawrych bgawrych merged commit db39bb1 into apache:master Jul 29, 2022
@hankaj hankaj mentioned this pull request Jul 29, 2022
Closed
@hankaj hankaj deleted the multivariate_normal_bug branch September 6, 2022 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
5 participants
@hankaj @mxnet-bot @bgawrych @DominikaJedynak @mseth10