do not let a page become a child of itself #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
commented
Sep 12, 2024
| @@ -421,6 +421,16 @@ describe('Pages', function() { | |||
| assert.strictEqual(page.rank, 1); | |||
| }); | |||
|
|
|||
| it('is not able to move a page under itself', async function() { | |||
| await assert.rejects( | |||
There was a problem hiding this comment.
Love that assert.rejects need to use it more, it's very awkward to write this kind of test correctly otherwise, often done wrong
BoDonkey
previously approved these changes
Sep 18, 2024
myovchev
approved these changes
Sep 20, 2024
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Sep 26, 2024
* upstream/main: fix oversights in add missing schema fields (apostrophecms#4736) upgrate stylelint-config-apostrophe to 4.2.0 (apostrophecms#4735) PRO-6472: at startup, automatically supply a value for any new schema property that has a def or fallback def (apostrophecms#4721) fix sass warning (apostrophecms#4730) fix piecesFilters with dynamic choices (apostrophecms#4731) hotfix 4.7.1 (apostrophecms#4733) PRO-6591: parked fields overrides (apostrophecms#4732) do not let a page become a child of itself (apostrophecms#4726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
What are the specific steps to test this change?
See unit tests. I don't know how an end user can convince the UI to attempt it, but the important thing is that the backend API refuse to do it, which is what I've implemented here. (My new test did fail until I made the fix.)
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: