Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming updates November 2021 (done) #163

Open
19 tasks done
tima101 opened this issue Aug 24, 2021 · 2 comments
Open
19 tasks done

Upcoming updates November 2021 (done) #163

tima101 opened this issue Aug 24, 2021 · 2 comments
Assignees
Labels
Ready to test - Async Issue is implemented and ready for testing. PR is merged.

Comments

@tima101
Copy link
Member

tima101 commented Aug 24, 2021

Move changes to book/10-end, decided against creating Chapter 11:

  • retire inefficient generateNumberSlug and generateSlug - either use _id as slug or generate unique values with Math.random (Chapter 11, explain motivation)
  • bodyParser.raw to express.raw for Stripe's webhook (change content inside chapter in question)
  • GA events example (Chapter 11: screenshots from GA dashboard)



  • node v14.18.1
  • next v12.0.3 (webpack v5, add two plugins for babel, react and react-dom v17.0.2)
  • @mui/material v5.0.6 (breaking changes)
  • retire dotenv for app; update next.config.js and update names for environmental variables; update README file

Notes:

  • imports:
    npx @mui/codemod v5.0.0/preset-safe pages
    npx @mui/codemod v5.0.0/preset-safe components
    
  • MyApp, MyDocument
  • Select, event.stopPropagation()
  • removed <InputLabel>Notification type</InputLabel>
  • theme, createTheme, type -> mode
  • versions for mobx, mobx-react
  • version of eslint in api
  • upgraded versions for socket.io-client, socket.io, @types/socket.io, remove @types/socket.io-client, update socket.ts, update store/index.ts


  • explain firing of MyDocument.render and MyApp.getInitialProps:
console.log('MyDocument.render');
console.log('MyApp.getInitialProps');

explain firing of lifecycle methods:

console.log('DiscussionPageComp.componentDidMount');

console.log('before condition DiscussionPageComp.componentDidUpdate');

console.log('inside condition DiscussionPageComp.componentDidUpdate');

console.log('DiscussionPageComp.componentWillUnmount');

explain firing of useEffect hook:

console.log('useEffect 1 for DiscussionPageCompFunctional');

console.log('useEffect 2 for DiscussionPageCompFunctional');
  • move changes from book/11-end to book/10-end; remove book/11-begin and book/11-end
  • replace codebase inside saas with codebase inside book/10-end
  • review instructions for Node.js 14 running on 64bit Amazon Linux 2:
    • engines in package.json
    • build locally before deploy; only start script runs from package.json at AWS EB
    • review config.yml
    • review names of env vars
  • redeploy demo (https://saas-app.async-await.com and https://saas-api.async-await.com)
@marcosCapistrano
Copy link

marcosCapistrano commented Aug 30, 2021

About getInitialProps: https://nextjs.org/docs/api-reference/data-fetching/getInitialProps
Should it be changed to the getStaticProps or getServerSideProps in fetching data for pages?

EDIT: sorry if this isn't the right place, is there a section for questions/suggestions?

@tima101
Copy link
Member Author

tima101 commented Aug 31, 2021

@marcosCapistrano Thanks for suggestion. I don't think there are many (or any) instances for using getStaticProps (fetch data and render page at build time instead of request time). But worth looking into it. I added task to my list.

tima101 added a commit that referenced this issue Nov 23, 2021
@async-labs async-labs locked as resolved and limited conversation to collaborators Nov 23, 2021
@tima101 tima101 added the Downhill - Async Issue is being actively implemented, interruptions are discouraged. PR is under review. label Nov 23, 2021
@tima101 tima101 added Ready to test - Async Issue is implemented and ready for testing. PR is merged. and removed Downhill - Async Issue is being actively implemented, interruptions are discouraged. PR is under review. labels Dec 1, 2021
@tima101 tima101 pinned this issue Dec 1, 2021
@tima101 tima101 changed the title Upcoming updates November 2021 Dec 1, 2021
@tima101 tima101 unpinned this issue Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready to test - Async Issue is implemented and ready for testing. PR is merged.
2 participants