-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn into ES module #870
base: esm
Are you sure you want to change the base?
Turn into ES module #870
Conversation
BREAKING CHANGE: This is an ES module now.
Validated via ESM module resolution.
This PR poses the question: How do we want downstream libraries consume diagram-js? In bpmn-js and other libraries we currently consume like this:
Also possible right now, explicit import:
As we create ES modules with an Proposed in this PR we force our users to switch to explicit imports, which is a major breaking change for all consumers (cf. bpmn-js test ⬇️):
So we have three options:
|
If we are to ship this, we could consider writing a codemod to make the migration easier (for example with https://github.com/facebook/jscodeshift). |
This bumps dependencies to ES modules.
This turns diagram-js to be an ES module.
Depends on #869
Closes #863