Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): added Hero Button #373

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

NishantSinghhhhh
Copy link

I Have added the Hero Button

Recording.2024-10-18.225505.mp4

This is the Preview of the Button

Copy link

🚀 Preview deployed to: https://483001fe.animata.pages.dev

animata/button/hero-button.tsx Outdated Show resolved Hide resolved
content/docs/button/hero-button.mdx Outdated Show resolved Hide resolved
Copy link
Author

@NishantSinghhhhh NishantSinghhhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir changed the requested changes

Copy link

🚀 Preview deployed to: https://51c16df3.animata.pages.dev

Copy link
Author

@NishantSinghhhhh NishantSinghhhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

Copy link

🚀 Preview deployed to: https://a7cb37e1.animata.pages.dev

@hari hari linked an issue Oct 23, 2024 that may be closed by this pull request
Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NishantSinghhhhh The text is touching the arrow button, you need to fix the spacing on the start of the text.

content/docs/button/hero-button.mdx Outdated Show resolved Hide resolved
content/docs/button/hero-button.mdx Outdated Show resolved Hide resolved
animata/button/hero-button.tsx Outdated Show resolved Hide resolved
@sudhashrestha
Copy link
Contributor

Hi @NishantSinghhhhh Please link the associated issue in this PR. Thanks

@NishantSinghhhhh
Copy link
Author

@sudhashrestha ma'am, the PR Number is #373

Copy link
Author

@NishantSinghhhhh NishantSinghhhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shifted the text a bit and also, used group property of Tailwind and removed use state hook

Copy link
Author

@NishantSinghhhhh NishantSinghhhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved the conversations

@NishantSinghhhhh
Copy link
Author

NishantSinghhhhh commented Oct 25, 2024

@hari sir I have opened a new PR for the hero button , please have a look at it and review it , it is having all the changes that you requested

#377- PR

Copy link

🚀 Preview deployed to: https://db03ebbd.animata.pages.dev

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
Copy link

🚀 Preview deployed to: https://f9912787.animata.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants