Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Open Graph attributes for the cc legal db page #260

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

egbadon-victor
Copy link
Contributor

@egbadon-victor egbadon-victor commented Oct 31, 2024

Fixes

Description

This PR adds the appropriate Open graph meta tags for the legal db project.

Technical details

This PR includes the following meta tags;

  • og:url
  • og:title
  • og:type
  • og:description
  • og:image
  • og:locale
  • og:locale:alternate

Tests

  • Run the development server on your machine
  • Install the localhost Open graph checker on your browser (chrome)
  • Open the devlopment instance of the project and click the extension
  • Copy the generate url and test on both facebook and x to confirm the appropriate og meta content is being displayed.

Screenshots

image
Screenshot 2024-10-31 at 20 34 46

Additional Information

Link to the official plugin page.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
@egbadon-victor egbadon-victor requested review from a team as code owners October 31, 2024 19:28
@egbadon-victor egbadon-victor requested review from TimidRobot, possumbilities and krysal and removed request for a team October 31, 2024 19:28
@egbadon-victor egbadon-victor changed the title [Feature] Add og attributes for the cc legal db page Oct 31, 2024
@TimidRobot TimidRobot changed the base branch from main to vocab-refresh November 1, 2024 17:39
@TimidRobot TimidRobot changed the base branch from vocab-refresh to main November 1, 2024 17:39
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure this is synced with the main branch

legal_db/templates/legal_db/base.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/base.html Outdated Show resolved Hide resolved
@egbadon-victor
Copy link
Contributor Author

@TimidRobot all changed noted. I have duly implemented them.

Question: Is there any specific reason why the <meta property="og:locale:alternate" content="ru_RU" /> locale is present in the chooser repo. And if there isn't, can I raise an issue there, implementing these suggested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants