Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform)!: state transition fee increase and priorities #1750

Merged
merged 28 commits into from
Mar 8, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

If the mempool was full users had no way to incentivize proposers to include their state transitions over other ones. With this PR we introduce a fee multiplier. This fee multiplier is only on processing costs. The greater the fee multiplier the more priority your transaction will receive in the mempool.

What was done?

Introduced a fee multiplier

How Has This Been Tested?

Added a test on check tx that showed the priority was higher with a fee multiplier, also shows this transaction cost more in processing fees

Breaking Changes

State transitions now have a fee multiplier u16 field.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone
@PastaPastaPasta
Copy link
Member

Can you do cargo fmt in another PR? looks like a lot of it is unrelated to your first commit?

@QuantumExplorer
Copy link
Member Author

@PastaPastaPasta all prs should have cargo fmt done, otherwise the linter should fail CI.

packages/rs-dpp/src/lib.rs Outdated Show resolved Hide resolved
@shumkov shumkov changed the title feat(platform)!: fee multiplier and priorities Mar 8, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer QuantumExplorer merged commit 8030d3d into v1.0-dev Mar 8, 2024
63 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/feeMultiplierAndPriorities branch March 8, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants