-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform)!: state transition fee increase and priorities #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you do cargo fmt in another PR? looks like a lot of it is unrelated to your first commit? |
@PastaPastaPasta all prs should have cargo fmt done, otherwise the linter should fail CI. |
…platform into feat/feeMultiplierAndPriorities
shumkov
reviewed
Mar 8, 2024
shumkov
requested changes
Mar 8, 2024
...state_transition/state_transitions/identity/identity_topup_transition/v0/value_conversion.rs
Show resolved
Hide resolved
...state_transition/state_transitions/identity/identity_update_transition/v0/json_conversion.rs
Outdated
Show resolved
Hide resolved
shumkov
requested changes
Mar 8, 2024
...ansition/state_transitions/contract/data_contract_create_transition/state_transition_like.rs
Outdated
Show resolved
Hide resolved
...ansition/state_transitions/contract/data_contract_create_transition/state_transition_like.rs
Outdated
Show resolved
Hide resolved
...c/state_transition/state_transitions/contract/data_contract_update_transition/methods/mod.rs
Outdated
Show resolved
Hide resolved
…platform into feat/feeMultiplierAndPriorities
shumkov
requested changes
Mar 8, 2024
packages/rs-dpp/src/state_transition/state_transitions/common_fields.rs
Outdated
Show resolved
Hide resolved
shumkov
requested changes
Mar 8, 2024
shumkov
requested changes
Mar 8, 2024
packages/rs-sdk/src/platform/transition/withdraw_from_identity.rs
Outdated
Show resolved
Hide resolved
shumkov
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
If the mempool was full users had no way to incentivize proposers to include their state transitions over other ones. With this PR we introduce a fee multiplier. This fee multiplier is only on processing costs. The greater the fee multiplier the more priority your transaction will receive in the mempool.
What was done?
Introduced a fee multiplier
How Has This Been Tested?
Added a test on check tx that showed the priority was higher with a fee multiplier, also shows this transaction cost more in processing fees
Breaking Changes
State transitions now have a fee multiplier u16 field.
Checklist:
For repository code-owners and collaborators only