Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: reduce platform max block gas #1989

Draft
wants to merge 345 commits into
base: master
Choose a base branch
from
Draft

chore!: reduce platform max block gas #1989

wants to merge 345 commits into from

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 23, 2024

Issue being fixed or feature implemented

With the current max block size, the block contains about 1700 simple document batch transitions that make block execution pretty slow (up to 30 seconds), which in turn affects insertion time badly (UX).

What was done?

  • Reduced block max gas by three times.

How Has This Been Tested?

None

Breaking Changes

The genesis consensus param is changed. Previously created networks won't be compatible.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone
pshenmic and others added 30 commits March 15, 2024 09:51
@pshenmic
chore(dashmate): readme fixes (#1624)
08f6b18
@markin-io
fix(drive): internal error on querying proofs (#1747)
d2d389e
@QuantumExplorer
feat: created at updated at from block time (#1780)
f133e81
@markin-io
chore: fix npm audit for follow-redirects package (#1781)
ea18e91
@QuantumExplorer
feat: query retry on race condition (#1776)
9c8d72c
@PastaPastaPasta
ci: enforce warnings as errors (#1783)
6a62ae3
@QuantumExplorer
feat(platform)!: created at block height and variants (#1784)
77d62ab
@lklimek
build: rs-tenderdash-abci 0.14.0-dev.9 (#1782)
97dc0df
@lklimek
fix(sdk)!: don't allow duplicate mock expectations (#1788)
faefb58
@pauldelucia
fix: identity add keys in strategy tests (#1727)
51797a6
@pauldelucia
feat: updated descriptions and function names in strategy tests plus …
5f93578 
…readme file (#1785)
@thephez
ci: update doc build branch in action config (#1748)
85a7f6c
@markin-io
feat(dapi): use broadcast_tx instead of deprecated broadcast_tx_sync (#…
5493ae9 
…1775)
@QuantumExplorer @lklimek
@markin-io @shumkov
feat: identity state transition validation fixes (#1786)
807942e 
Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: markin.io <markin.io210@gmail.com>
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@shumkov
chore(release): update changelog and bump version to 1.0.0-dev.9 (#1790)
d6688be
@pauldelucia
fix(strategy-tests): default identity nonce and document op contract …
8c47e82 
…id (#1777)
@QuantumExplorer
test: added a test registering many random contracts in strategy tests (
4d8af75 
#1791)
@QuantumExplorer
fix(platform)!: max state transition size (#1792)
1582458
@QuantumExplorer
perf(platform)!: use inline on versioned functions (#1793)
d672ed8
@QuantumExplorer
feat(platform)!: various document validation improvements (#1795)
02481fc
@shumkov
feat(dpp)!: validate document type name (#1798)
6947672
@markin-io
fix: state transition already in chain error on low credit transfer a…
1ac3638 
…mount (#1797)
@pauldelucia
feat(strategy-tests): add extra_keys field for StartIdentities and us…
b8fd57d 
…e random identities for transfers (#1794)
@pauldelucia
feat: pass asset lock vector rather than callback in strategies
0f6a465
@QuantumExplorer
feat(platform)!: mitigate issues of asset lock based transitions (#1796)
3014b6f
@pauldelucia
Merge branch 'v1.0-dev' into strategy-asset-lock-proof-refactor
08bb6f6
@QuantumExplorer
feat(drive-abci)!: better processing costs of state transitions (no s…
3be578a 
…chema processing improvements) (#1800)
@pauldelucia
Merge branch 'v1.0-dev' into strategy-asset-lock-proof-refactor
44608ed
@pauldelucia
refactor(strategy-tests): take a vector of asset lock proofs rather t…
21cd7f7 
…han a callback (#1799)
@QuantumExplorer
chore(sdk): export various libraries in rs-sdk (#1802)
642ff91
shumkov and others added 22 commits July 16, 2024 23:03
@shumkov
ci: fix docker build for release (#1965)
76a6a44
@shumkov
chore(release): update changelog and bump version to 1.0.0-beta.2 (#1966
613cfdd 
)
Fix release process
d4cec25
@ktechmidas
fix(ci): Fix issue with empty dir in release process (#1967)
a89adf9
@thephez
chore: add comments to the platform.proto file (#1641)
3930e2e
@QuantumExplorer
feat(dpp): decomposed integer types for document type properties (#1968)
77f7a96
@shumkov
ci: fix release docker images (#1969)
4b6688a
@QuantumExplorer
feat(platform)!: max field size and some clean up of versioning (#1970)
785dd6c
@QuantumExplorer
chore(platform)!: updated fees (#1971)
782fd97
@shumkov
chore: activate platform on EHF fork (#1972)
d097ef3
@shumkov
chore(release): update changelog and bump version to 1.0.0-beta.3 (#1973
bf84d9d 
)
@shumkov
refactor(drive): don't use private bound for public trait (#1974)
811dfa0
@shumkov
chore(drive)!: don't use 0.0.0.0 as default listen IP (#1976)
4942906
@shumkov
fix(drive): drive and tenderdash are constantly restarting (#1978)
cd07fd4
@shumkov
fix(dashmate): configure devnet quorums (#1979)
811817a
@shumkov
fix: expected service to be a string with ip address and port (#1980)
2b4ccfa
@shumkov
chore(release): update changelog and bump version to 1.0.0-beta.4 (#1981
6e0842f 
)
@pauldelucia
Merge branch 'v1.0-dev' into fix/select-random-identities-for-strateg…
3d44a69 
…y-documents
@pauldelucia
fix: voting test
a4ad9c7
@pauldelucia
fix: not all identities were being used to broadcast documents in str…
9a177ff 
…ategy tests (#1852)
@QuantumExplorer
fix(platform)!: add hyphen to match for contested documents on Dashpay (
d3170b9 
#1982)
@shumkov
chore: reduce platform max block gas
7acce0c
@shumkov shumkov added this to the v1.0.0 milestone Jul 23, 2024
QuantumExplorer
QuantumExplorer requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge yet
@shumkov shumkov marked this pull request as draft July 23, 2024 16:49
@shumkov shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:05
@thephez thephez removed this from the v1.0.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet