chore(Demos): add SSR support for all react-live demos #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdf5bc2:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11m PerformanceLighthouse report
|
tujoworker
force-pushed
the
chore/react-live-ssr
branch
from
ee111b3
to
616fa31
Compare
tujoworker
force-pushed
the
chore/react-live-ssr
branch
from
616fa31
to
b427c43
Compare
tujoworker
force-pushed
the
chore/react-live-ssr
branch
from
b427c43
to
cdf5bc2
Compare
langz
approved these changes
May 31, 2022
packages/dnb-design-system-portal/src/docs/uilib/extensions/payment-card/Examples.js
Show resolved
Hide resolved
|
🎉 This PR is included in version 9.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantages of SSR (SSG) support is that the build of the portal will run all the code examples – and if there is a JavaScript/React issue, the build will break.
We use
react-livefor showing demos/examples. It used to support SSR before v2.3.0 (a year ago) but missed it when they converted it to React Hooks. But they want to support it like this issue shows. So I made a PR. But until they eventually release it, I made a quick build of it and use it directly inside our repo.