Allow to run tests in local environment + fix tests for it #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Jan 11, 2023
docker/autotests.Dockerfile
Outdated
| RUN go mod download | ||
| COPY ./ . | ||
|
|
||
| CMD go test -race -v -timeout 2m ./... -gocheck.v |
There was a problem hiding this comment.
I'm not sure about your environment. The first thought comes to my mind is using docker to start a MySQL at 3306 and running go test outside the docker. The good point is if I change some code, I don't need to build the docker image again and no need to prune unused docker local volumes periodically. (in last week I found my disk is almost full, docker volumns of another project's integration tests occupied ~200GB 😂 )
atercattus
force-pushed
the
atercattus/allow-to-run-tests-in-local-docker
branch
from
4d252f2
to
9e7980a
Compare
lance6716
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can run our tests on CI stage (github actions). But it's difficult for local usage 😅
Now I'm working on #650 and I really need tests locally.
I'm trying to use act, but it's not working for me.
So I wrote a docker env for it. Also, I did tiny refactoring and fixes in tests for it.
All we need to run tests is simple
$ make test-local.