Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panicking if a bad regexp is returned after converting glob pattern to regexp #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid panicking if a bad regexp is returned after converting glob pattern to regexp #983

wants to merge 1 commit into from

Conversation

rdelcampog
Copy link

Fixes #982

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check
codespearhead
codespearhead suggested changes Apr 5, 2024
View reviewed changes
Copy link

@codespearhead codespearhead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you implement that change in all other instances of regexp.MustCompile in the codebase?
@ysmood ysmood force-pushed the main branch 2 times, most recently from 5da0786 to 0c7bc12 Compare June 17, 2024 08:39
@ysmood ysmood force-pushed the main branch 7 times, most recently from 834f2bf to c42b414 Compare July 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@rdelcampog @codespearhead