Fix Clang warning diagnostics #835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgavris
commented
Apr 3, 2022
| default: | ||
| llvm_unreachable("unhandled spir-v version"); | ||
| break; | ||
| #endif |
There was a problem hiding this comment.
For Clang / LLVM, these probably don't make sense anymore as they are covered, if the warnings are kept as errors.
jgavris
commented
Apr 3, 2022
| @@ -48,10 +45,6 @@ clspv::ArgKind GetArgKindForType(Type *type); | |||
| // ro_image - sampled image | |||
| // wo_image - storage image | |||
| // sampler - sampler | |||
| inline const char *GetArgKindNameForType(llvm::Type *type) { | |||
jgavris
commented
Apr 3, 2022
| @@ -29,7 +29,7 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) | |||
| project(clspv) | |||
| endif() | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 14) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
/Users/jgavris/code/clspv/lib/ReplaceOpenCLBuiltinPass.cpp:3346:25: warning: hexadecimal floating literals are a C++17 feature [-Wc++17-extensions]
const double k_pi = 0x1.921fb54442d18p+1;
|
Please take a look at the build failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://clang.llvm.org/docs/UsersManual.html#options-to-control-error-and-warning-messages