Vk protected content final #8258
Merged
+68
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to get the caching of the command buffer as well as building protected version of the depth buffer in that swap chain path.
Pass the queue and the queue family index.
Push constant and subpass.
Adding the blitter to the list of protected paths.
The Render target was not storing the protection level.
poweifeng
reviewed
Nov 8, 2024
| @@ -151,7 +151,8 @@ void VulkanBlitter::resolve(VulkanAttachment dst, VulkanAttachment src) { | |||
| } | |||
| #endif | |||
|
|
|||
| VulkanCommandBuffer& commands = mCommands->get(); | |||
| VulkanCommandBuffer& commands = dst.texture->getIsProtected() ? | |||
| mCommands->getProtected() : mCommands->get(); | |||
filament/backend/src/vulkan/platform/VulkanPlatformSwapChainImpl.cpp
Outdated
Show resolved
Hide resolved
filament/backend/src/vulkan/platform/VulkanPlatformSwapChainImpl.cpp
Outdated
Show resolved
Hide resolved
Minor clean ups.
|
Feedback addressed. |
poweifeng
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of the protected contend feature: