Fix compilation error when HWY_COMPILER_GCC_ACTUAL < 1300
#120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is caused by
hwy::ConvertScalarTo
called inEmbeddingScaling
. The comment onEmbeddingScaling
said that it's for rounding the float to bf16 to match Gemma's Embedder. It calls this version of the template function:When
HWY_COMPILER_GCC_ACTUAL < 1300
and there is no built-in function__builtin_bit_cast
, It will not beconstexpr
. However,constexpr
attribute ofEmbeddingScaling
only followsSqrt
, which may cause compilation errors. So I open this PR to fix it.