Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Update Dashboard with Style and Structure Improvements #5421

Open
wants to merge 2 commits into
base: mdl-1.x
Choose a base branch
from

Conversation

amalbouazza
Copy link

Hello,

This pull request includes modifications to the dashboard, aiming to enhance its style and structure. Here's a summary of the major changes:

HTML (dashboard/ index.html):

Added semantic tags to improve structure and accessibility.
Rearranged elements for a more logical layout.
Fixed improperly closed tags and minor syntax issues.

CSS (dashboard / style.css):

Refactored the stylesheet for better readability and organization.
Standardized class names to follow conventions.
Added explanatory comments to enhance code understanding.

These changes are intended to optimize code maintainability and improve the development experience. Feel free to provide feedback or suggestions.

Use HTTPS for External Resources:
Change the protocol in your external resource URLs to HTTPS to ensure secure connections.

<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:regular,bold,italic,thin,light,bolditalic,black,medium&amp;lang=en">
<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/material-design-lite@1.3.0/dist/material.cyan-light_blue.min.css">

Remove Deprecated Meta Tags:
The meta tags for adding to the homescreen are outdated and not needed for modern web applications. You can remove them.
html
<meta name="mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black">
<meta name="apple-mobile-web-app-title" content="Material Design Lite">

Accessibility Improvement:
Add alternative text to the images for better accessibility.
<img src="images/user.jpg" alt="User Avatar" class="demo-avatar">
Copy link

google-cla bot commented Nov 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@amalbouazza amalbouazza reopened this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant