Fix mdl-layout screen resize memory leak #5431
Open
+12,888
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove event handlers from `window` when the tooltip is not showing. - Get rid of component deconstruction remnants. `downgradeElements` was updated in dec 2015 to not actually do any downgrading, because at the time none of the components needed deconstruction. A memory leak was then added to the Tooltip component in May 2016. These changes to `downgradeElements` were problematic: - It still removes the `data-upgraded` attributes from dom elements, even though no deconstruction actually happened. This means that calling `upgradElement` again will double-upgrade the element. - the `createComponents_` array no longer serves any purpose.
Fix memory leaks.
Fix Radio focus bug.
…placeholder Fix undefined textfield placeholder
Modify textfield fix to remove ?
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add CI Build for tests
Co-authored-by: Ryan Brown <ryan@derivita.com>
jakelauritsen
force-pushed
the
jakelauritsen/fix-mdl-layout-screen-resize-mem-leak
branch
from
1d2d166
to
fde3ac6
Compare
jakelauritsen
force-pushed
the
jakelauritsen/fix-mdl-layout-screen-resize-mem-leak
branch
from
7f5f53f
to
03133a7
Compare
jakelauritsen
force-pushed
the
jakelauritsen/fix-mdl-layout-screen-resize-mem-leak
branch
from
03133a7
to
c63e700
Compare
jakelauritsen
force-pushed
the
jakelauritsen/fix-mdl-layout-screen-resize-mem-leak
branch
from
30409eb
to
cbb40d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.