Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): simplifications of code from staticcheck #10740

Merged
merged 7 commits into from
Sep 16, 2024
Merged

chore(spanner): simplifications of code from staticcheck #10740

merged 7 commits into from
Sep 16, 2024
+12 −22

Conversation

egonelbre
Copy link
Contributor

  • chore(spanner): simplify test code with strings.EqualFold
  • chore(spanner): simplify return of bool result
  • chore(spanner): simplify slice non-empty checks
  • chore(spanner): avoid type assertions in switch

Updates #9784
@egonelbre egonelbre requested review from a team as code owners August 22, 2024 13:58
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 22, 2024
@rahul2393 rahul2393 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) September 16, 2024 08:44
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2024
@rahul2393 rahul2393 merged commit d9fc969 into googleapis:main Sep 16, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
3 participants
@egonelbre @rahul2393 @kokoro-team