Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tree-sitter-subtree #11663

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Improve tree-sitter-subtree #11663

merged 4 commits into from
Sep 30, 2024

Conversation

chtenb
Copy link
Contributor

@chtenb chtenb commented Sep 8, 2024

Make unnamed nodes visible in subtree view, to make it easier to debug things related to tree sitter trees.

Before After
before after
the-mikedavis
the-mikedavis reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant to put anonymous nodes in the display but it doesn't look as crowded as I thought 👍

There's a unit test in syntax.rs for the display that will anonymous nodes added to fix the CI
@the-mikedavis the-mikedavis added A-tree-sitter Area: Tree-sitter A-command Area: Commands labels Sep 11, 2024
@chtenb
Copy link
Contributor Author

chtenb commented Sep 22, 2024

I've updated the tests
@archseer archseer merged commit 8cdce92 into helix-editor:master Sep 30, 2024
6 checks passed
plul pushed a commit to plul/helix that referenced this pull request Oct 13, 2024
@chtenb @plul
Improve tree-sitter-subtree (helix-editor#11663)
d7114ba 
* Make unnamed nodes visible in subtree view

* Refine command description

* Update generated docs

* Update unit test expected output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands A-tree-sitter Area: Tree-sitter
3 participants
@chtenb @the-mikedavis @archseer