[Bug][jupyter] Serialization error on GeoDataFrames with multiple geometry columns #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
columns Co-authored-by: Felix Lattemann <Felix.Lattemann@bmw.de> Co-authored-by: Andreas Hackeloeer <Andreas.Hackeloeer@bmw.de> Signed-off-by: Matthias Kraus <matthias.kb.kraus@bmw.de>
KrausMatthias
changed the title
|
Hi @heshan0131, Hi @igorDykhta, Hi @jwasilgeo, would you have time to take a short look at this bugfix and raise any issues/considerations we might need to fix before this can be merged? Greatly appreciating your work on keplergl :) |
heshan0131
approved these changes
Jul 10, 2023
|
Hi @heshan0131 , thanks for the review! What can I do to get this merged and released? Best regards |
|
Hi @heshan0131, sorry to ping you, when do you think this can be merged? I would be happy to contribute some more bugfixes if there is interest from your side :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a GeoDataFrame with multiple geometry columns, add_data fails with a serialization error, as currently only the "geometry" column is converted to WKT.
This uses to_wkt introduced by GeoPandas in version 0.9.0 which converts all columns of type geometry in the dataframe to WKT.
Besides the issue with multiple geometry columns this also fixes:
.add_data(gdf)twice [Bug] #1240, as to_wkt in geopandas does a copy internally, which avoids overwriting the geometry column with the WKT string column.