Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: chapter_tree/binary_tree.md #1502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

translation: chapter_tree/binary_tree.md #1502

wants to merge 1 commit into from
+20 −20

Conversation

magentaqin
Copy link
Contributor

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.
QiLOL
QiLOL reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@QiLOL QiLOL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @magentaqin, thanks for the contribution; it looks great; please check the comment for the minor advice.
en/docs/chapter_tree/binary_tree.md
- The <u>height</u> of a node: The number of edges from the farthest leaf node to the node.

![Common Terminology of Binary Trees](binary_tree.assets/binary_tree_terminology.png)

!!! tip

Please note that we typically define "height" and "depth" as "the number of edges traversed", but some problems or textbooks may define them as "the number of nodes traversed". In such cases, both height and depth need to be incremented by 1.
Please note that we usually define "height" and "depth" as "the number of edges passed", but some questions or textbooks may define them as "the number of nodes passed". In this case, both height and depth need to be incremented by 1.
Copy link
Contributor

@QiLOL QiLOL Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, using traversed is more accurate instead of passed.
@krahets krahets changed the title doc: translate chapter_tree/binary_tree.md to English Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@magentaqin @QiLOL