Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note for 1.31.0 #5970

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Nov 7, 2024

Screenshot 2024-11-11 at 10-27-11 1 31 0 release notes — Armeria release notes

@jrhee17 jrhee17 added this to the 1.31.0 milestone Nov 7, 2024
@jrhee17 jrhee17 marked this pull request as ready for review November 7, 2024 05:25
.build();

// return a TlsKeyPair dynamically
TlsKeyPair tlsKeyPair = hostname -> TlsKeyPair.of(...);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TlsKeyPair tlsKeyPair = hostname -> TlsKeyPair.of(...);
TlsProvider tlsProvider = hostname -> TlsKeyPair.of(...);
Comment on lines 32 to 45
- You can customize how in-flight requests are terminated during server shutdown by specifying a <type://GracefulShutdown>. #5941
```java
GracefulShutdown gracefulShutdown =
GracefulShutdown.builder()
.shutdownErrorFunction((ctx, req) -> {
logger.info("Not gracefully terminated!");
return new MyException();
})
.build();

Server
.builder()
.gracefulShutdown(gracefulShutdown);
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this PR from 1.31.0

Suggested change
- You can customize how in-flight requests are terminated during server shutdown by specifying a <type://GracefulShutdown>. #5941
```java
GracefulShutdown gracefulShutdown =
GracefulShutdown.builder()
.shutdownErrorFunction((ctx, req) -> {
logger.info("Not gracefully terminated!");
return new MyException();
})
.build();
Server
.builder()
.gracefulShutdown(gracefulShutdown);
```
Comment on lines 53 to 54
ResponseEntity response = ResponseEntity.of(200);
ResponseEntity response = ResponseEntity.of("Hello!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ResponseEntity response = ResponseEntity.of(200);
ResponseEntity response = ResponseEntity.of("Hello!");
ResponseEntity<Object> response = ResponseEntity.of(200);
ResponseEntity<String> response = ResponseEntity.of("Hello!");
Comment on lines 80 to 86
- An experimental `micrometer-context` module has been added. You can propagate <type://RequestContext> via [Project Reactor](https://projectreactor.io/)'s `Context`. #5145 #5577
```java
ContextRegistry
.getInstance()
.registerThreadLocalAccessor(new RequestContextThreadLocalAccessor());
Hooks.enableAutomaticContextPropagation();
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this from the release notes since it is excluded from the publish?


## 🏚️ Deprecations

- <type://ServerBuilder#gracefulShutdownTimeout(Duration,Duration)> has been deprecated in favor of <type://ServerBuilder#gracefulShutdown(GracefulShutdown)>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Suggested change
- <type://ServerBuilder#gracefulShutdownTimeout(Duration,Duration)> has been deprecated in favor of <type://ServerBuilder#gracefulShutdown(GracefulShutdown)>.
Comment on lines 118 to 120
- Jetty
- 11.0.22 → 11.0.24
- 12.0.12 → 12.0.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Jetty
- 11.0.22 → 11.0.24
- 12.0.12 → 12.0.14
- Jetty
- 11.0.22 → 11.0.24
- 12.0.12 → 12.0.14
Comment on lines 133 to 136
- Scala
- 2.12.19 → 2.12.20
- 2.13.14 → 2.13.15
- 3.4.2 → 3.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Scala
- 2.12.19 → 2.12.20
- 2.13.14 → 2.13.15
- 3.4.2 → 3.6.1
- Scala
- 2.12.19 → 2.12.20
- 2.13.14 → 2.13.15
- 3.4.2 → 3.6.1
Comment on lines 139 to 141
- Tomcat
- 9.0.91 → 9.0.96
- 10.1.26 → 10.1.31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tomcat
- 9.0.91 → 9.0.96
- 10.1.26 → 10.1.31
- Tomcat
- 9.0.91 → 9.0.96
- 10.1.26 → 10.1.31
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍


## 🌟 New features

- You can now set TLS configurations dynamically using `TlsProvider` #5033 #5228
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- You can now set TLS configurations dynamically using `TlsProvider` #5033 #5228
- You can now set TLS configurations dynamically using <type://TlsProvider>. #5033 #5228
```java
ServiceRequestContext ctx = ...;
String rawPath = ctx.rawPath();
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
NacosUpdatingListener.builder(nacosUri, "my-service")
...
.build());
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
## 📈 Improvements

- The GraalVM native image metadata has been updated to reflect recent code changes. #5946
- <type://XdsEndpointGroup> now supports `disable_active_health_check` #5879
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- <type://XdsEndpointGroup> now supports `disable_active_health_check` #5879
- <type://XdsEndpointGroup> now supports `disable_active_health_check`. #5879
- 9.0.91 → 9.0.96
- 10.1.26 → 10.1.31

## 🗑 Maybe ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @jrhee17. 🙇‍♂️🙇‍♂️

site/src/pages/release-notes/1.31.0.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ikhun Um <ih.pert@gmail.com>

## 🌟 New features

- You can now set TLS configurations dynamically using <type://TlsProvider> #5033 #5228
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • How about 'update' instead of 'set'?
  • No more bold keywords for each item?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants