[upgraded] to tslint 4.5.1

Summary: There have been a bunch of new rules, so I've enabled the ones that looked reasonable.

Reviewers: O2 Material Motion, #material_motion, featherless

Reviewed By: O2 Material Motion, #material_motion, featherless

Tags: #material_motion

Differential Revision: http://codereview.cc/D2931

package.json

@@ -42,7 +42,7 @@
     "sinon": "2.1.0",
     "sinon-chai": "2.9.0",
     "ts-loader": "2.0.3",
-    "tslint": "4.0.2",
+    "tslint": "4.5.1",
     "typescript": "2.2.1",
     "webpack": "2.3.1"
   }

packages/demos-react/package.json

@@ -5,7 +5,7 @@
     "pundle": "../../node_modules/.bin/pundle",
     "start": "yarn run pundle -- --dev",
     "clean": "rm -rf ./site/dist/*; mkdir -p ./site/dist/",
-    "lint": "../../node_modules/.bin/tslint -c ../../tslint.json --project tsconfig.json",
+    "lint": "../../node_modules/.bin/tslint -c ../../tslint.json --project tsconfig.json --type-check",
     "build": "yarn run clean; yarn run pundle",
     "deploy": "yarn run build; $( yarn bin )/firebase deploy"
   },

packages/experimental-addons/package.json

@@ -6,7 +6,7 @@
   "types": "dist/index.d.ts",
   "typescript:main": "src/index.ts",
   "scripts": {
-    "lint": "$( yarn bin )/tslint -c ../../tslint.json --project tsconfig.json",
+    "lint": "$( yarn bin )/tslint -c ../../tslint.json --project tsconfig.json --type-check",
     "test": "node ../../tools/test.js --only experimental-addons",
     "clean": "rm -rf ./dist/*; mkdir -p ./dist/",
     "build": "yarn run clean; $( yarn bin )/tsc"

packages/springs-adaptor-rebound/package.json

@@ -6,7 +6,7 @@
   "types": "dist/index.d.ts",
   "typescript:main": "src/index.ts",
   "scripts": {
-    "lint": "$( yarn bin )/tslint -c ../../tslint.json --project tsconfig.json",
+    "lint": "$( yarn bin )/tslint -c ../../tslint.json --project tsconfig.json --type-check",
     "test": "node ../../tools/test.js --only springs-adaptor-rebound",
     "clean": "rm -rf ./dist/*; mkdir -p ./dist/",
     "build": "yarn run clean; $( yarn bin )/tsc"

packages/streams-dom/package.json

@@ -5,7 +5,7 @@
   "main": "dist/index.js",
   "types": "src/index.ts",
   "scripts": {
-    "lint": "../../node_modules/.bin/tslint -c ../../tslint.json --project tsconfig.json",
+    "lint": "../../node_modules/.bin/tslint -c ../../tslint.json --project tsconfig.json --type-check",
     "test": "node ../../tools/test.js --only streams-dom",
     "clean": "rm -rf ./dist/*; mkdir -p ./dist/",
     "build": "yarn run clean; ../../node_modules/.bin/tsc"

packages/streams-react/package.json

@@ -6,7 +6,7 @@
   "types": "dist/index.d.ts",
   "typescript:main": "src/index.ts",
   "scripts": {
-    "lint": "$( yarn bin )/tslint -c ../../tslint.json --project tsconfig.json",
+    "lint": "$( yarn bin )/tslint -c ../../tslint.json --project tsconfig.json --type-check",
     "test": "node ../../tools/test.js --only streams-react",
     "clean": "rm -rf ./dist/*; mkdir -p ./dist/",
     "build": "yarn run clean; $( yarn bin )/tsc"

packages/streams/package.json

@@ -6,7 +6,7 @@
   "types": "dist/index.d.ts",
   "typescript:main": "src/index.ts",
   "scripts": {
-    "lint": "../../node_modules/.bin/tslint -c ../../tslint.json --project tsconfig.json",
+    "lint": "../../node_modules/.bin/tslint -c ../../tslint.json --project tsconfig.json --type-check",
     "clean": "rm -rf ./dist/*; mkdir -p ./dist/",
     "build": "yarn run clean; ../../node_modules/.bin/tsc",
     "test": "node ../../tools/test.js --only streams"

tslint.json

@@ -10,6 +10,7 @@
     "interface-name": [true, "never-prefix"],
     "jsdoc-format": true,
     "label-position": true,
+    "match-default-export-name": true,
     "new-parens": true,
     "no-angle-bracket-type-assertion": true,
     "no-conditional-assignment": true,
@@ -20,6 +21,7 @@
     "no-require-imports": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
+    "no-unbound-method": true,
     "no-use-before-declare": false,
     "no-var-keyword": true,
     "one-variable-per-declaration": [true, "ignore-for-loop"],
@@ -31,10 +33,13 @@
         "named-imports-order": "lowercase-last"
       }
     ],
+    "prefer-const": true,
+    "prefer-method-signature": true,
     "radix": true,
     "semicolon": [true, "always", "ignore-interfaces"],
     "switch-default": true,
     "triple-equals": [true, "allow-null-check"],
+    "typeof-compare": true,
     "use-isnan": true,
     "variable-name": [
       true,