Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullup filter does not toggle off with cycle-deinterlace-pullup.lua #14881

Closed
6 tasks done
elmimmo opened this issue Sep 18, 2024 · 0 comments · Fixed by #14885
Closed
6 tasks done

Pullup filter does not toggle off with cycle-deinterlace-pullup.lua #14881

elmimmo opened this issue Sep 18, 2024 · 0 comments · Fixed by #14885

Comments

@elmimmo
Copy link

elmimmo commented Sep 18, 2024

mpv Information

mpv 0.37.0 Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects
 built on Nov 30 2023 14:35:43
libplacebo version: v6.338.1
FFmpeg version: 5.1.4
FFmpeg library versions:
   libavutil       57.28.100
   libavcodec      59.37.100
   libavformat     59.27.100
   libswscale      6.7.100
   libavfilter     8.44.100
   libswresample   4.7.100

Other Information

- macOS version: macOS 14.6.1 (23G93)
- Source of mpv: `brew install mpv`
- Introduced in version: unknown

Reproduction Steps

The pullup filter should turn off, but does not, with the keyboard shortcut used to turn in on, shift + D, with the script cycle-deinterlace-pullup.lua installed.

  1. Get the script cycle-deinterlace-pullup.lua from the repo.

  2. Place it in ~/.config/mpv/scripts/.

  3. Open mpv and play a video.

  4. Press shift+D until the OSD reports the pullup filter is on:

    deinterlace: no
    pullup: yes

  5. Press shift+D once more and then again repeatedly.

Expected Behavior

Deinterlacing should keep toggling between no deinterlace, deinterlace and pullup, and the ODS report so.

Actual Behavior

Nothing happens: the pullup filter stays on, and deinterlacing mode does not toggle any more. The ODS reports so on every subsequent shift + D press, staying on:

deinterlace: no
pullup: yes

Log File

output.txt

Sample Files

No response

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@elmimmo elmimmo added the os:mac label Sep 18, 2024
guidocella added a commit to guidocella/mpv that referenced this issue Sep 19, 2024
This has been broken since b56e63e removed vf del. Replace it with vf
remove. Fixes mpv-player#14881.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants