Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples > Add coffee smoke #28967

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Examples > Add coffee smoke #28967

merged 4 commits into from
Jul 26, 2024

Conversation

brunosimon
Copy link
Contributor

Description

Add WebGPU/TSL coffee smoke example based on Three.js Journey lessons.
Uses a unique perlin texture for multiple animations and effects.

localhost_8083_examples_webgpu_tsl_coffee_smoke html
@brunosimon
Copy link
Contributor Author

I can't generate a screenshot that passes the test from Windows nor MacOS (I ran build first in both cases).
I added it to the exceptions.
@Mugen87 Mugen87 added this to the r168 milestone Jul 25, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 25, 2024

That's okay. I'll revisit the examples on the exception list and try to regenerate the screenshots at a later point. I had luck so far with an older Windows notebook so 🤞 .
@sunag
Copy link
Collaborator

sunag commented Jul 25, 2024

There's something strange with the smoke in WebGPU running on Windows.

image
@brunosimon
Copy link
Contributor Author

It's very inconsistent.
Indeed, it only occurs on windows, but it's not the only weird thing.

If I remove wrapS and wrapT, the texture stops repeating on MacOS, but it keeps on repeating on Windows.
Could it be because of how texture() handles the interpolation in the vertex shader @sunag ?

I pushed a simplified version on my sandbox https://github.com/brunosimon/three.js-tsl-sandbox/blob/master/issue-coffee-smoke/src/script.js
@sunag sunag merged commit 11a5e52 into mrdoob:dev Jul 26, 2024
11 checks passed
brunosimon added a commit to brunosimon/three.js that referenced this pull request Jul 28, 2024
@brunosimon
Examples: Add coffee smoke (mrdoob#28967)
b5d236e 
* Examples > Add coffee smoke

* Examples > Update coffee smoke screenshot

* Examples: Add coffee smoke screenshot to test exceptions
@Methuselah96 Methuselah96 mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@brunosimon @Mugen87 @sunag