Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeBuilder: Optional comparison methods #29049

Merged
merged 1 commit into from
Aug 1, 2024
Merged

NodeBuilder: Optional comparison methods #29049

merged 1 commit into from
Aug 1, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 1, 2024 •
edited
Loading

Related issue: Closes #29046

Description

Improve WGSL support for comparison expressions.

There's still equals left, I'll leave it for another PR.
@sunag sunag marked this pull request as ready for review August 1, 2024 16:37
@sunag sunag added this to the r168 milestone Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B
@sunag sunag merged commit b104696 into mrdoob:dev Aug 1, 2024
12 checks passed
@sunag sunag deleted the dev-comp-method branch August 1, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag