GLTFLoader: Fix sparse normalized. #29330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Sep 5, 2024
examples/jsm/loaders/GLTFLoader.js
Outdated
| @@ -3153,6 +3153,10 @@ class GLTFParser { | |||
|
|
|||
| } | |||
|
|
|||
| // Ignore normalized since we copy from sparse | |||
| const prevNormalize = bufferAttribute.normalized; | |||
There was a problem hiding this comment.
nit: Probably not necessary to save prevNormalize here, the original normalized variable is still in scope.
There was a problem hiding this comment.
Indeed, updated the commit
stephomi
force-pushed
the
fix_gltf_sparse
branch
from
73549c5
to
9eff0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufferAttribute.setXwill apply the normalisation when it should not when we copy from the sparse array.Simple file with morph target and color attributes (using sparse):
sparse.glb.zip