-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color: Improve documentation about color management #29545
Conversation
And that is correct. This is why we have The intensity is where the units come from, such as radiance (luminance), irradiance (illuminance), or radiant intensity (luminous intensity). In the case of lights, // In the case of The
|
Hm, admittedly I much prefer to use MeshBasicMaterial as a stand-in for an unlit material, which of course we do not actually have... but as it is, yes, perhaps it's better not to use MeshBasicMaterial as my example. A custom ShaderMaterial could be a better example. I would strongly rather not continue adding new shading features to MeshBasicMaterial, I would (if anything) remove them and make it unlit, but I know that's also impossible as a large breaking change. But I do still think we need to avoid saying |
If I remove the paragraph beginning “Minimum and maximum values...”, do you feel the rest is OK? I see that part will need some care. |
@WestLangley said
I really think that is the proper thing to do, if we are to be intellectually honest. |
We could alternatively use three.js/examples/jsm/environments/RoomEnvironment.js Lines 136 to 142 in 1e352b6
I think a core problem is that MeshBasicMaterial's support for any type of lighting is a surprise to most users when/if they discover it, we are trying to align the material intellectually to a concept that almost no one expects it to represent. Or that is my impression; perhaps I misjudge users' perceptions of the material! In any case, I think I have removed the messier parts of this PR now, please let me know if you see other issues, thanks again! |
The features such as light map support, and env map support, were included so If you want to think about a new |
Even that I suppose is challenging, what would it mean for an "unlit" material to have RGB values >1... questions for another time. 😅 Thank you for improving this PR! |
Currently the THREE.Color docs suggest that RGB values cannot extend beyond the range [0, 1], leading to some confusion as in this thread. I've added a more detailed introduction to the class, along with some information about handling of color spaces, as a lighter/easier alternative to the full color management guide.