Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: webgl-fallback - fix uniform/texture index allocation #29622

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #29610

CSMshaderNode exposes a faulty assumption in allocation of uniform buffer indices.
Correct Index allocation to take account of uniform buffers of arrays.

Copy link

github-actions bot commented Oct 11, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.92
170.93
689.92
170.93
+0 B
+0 B
WebGPU 814.71
219.35
814.82
219.39
+108 B
+39 B
WebGPU Nodes 814.22
219.22
814.33
219.26
+108 B
+40 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.94
111.81
462.94
111.81
+0 B
+0 B
WebGPU 537.56
145.04
537.67
145.07
+108 B
+38 B
WebGPU Nodes 493.67
134.77
493.78
134.81
+108 B
+40 B
@Mugen87 Mugen87 added this to the r170 milestone Oct 11, 2024
Minor code style clean up.
@Mugen87 Mugen87 merged commit 597481c into mrdoob:dev Oct 12, 2024
12 checks passed
@aardgoose aardgoose deleted the uniform-index branch November 6, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants