-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Wave docs to Wave documentation #5072
base: master
Are you sure you want to change the base?
Move Wave docs to Wave documentation #5072
Conversation
This PR shifts the Wave-specific guides over to the Wave repo and the Wave documentation site at: https://docs.seqera.io/wave
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@jason-seqera - this repo needs signed commits, which is why the CI check is failing. Easy to fix:
git commit --amend --sign
# Accept / save commit message as before
git push --force
I think we should keep on hold until we don't have the new wave docs ready |
Ah I assumed that there was a paired PR to add these back into the Seqera docs. Yes agree, they should be added there before they're removed here. |
@pditommaso @ewels - We could move over these tutorials in the meantime, though, and then that portion of the project would be complete. None of these specifically depend on the overall content refresh being complete. |
Aha - it's here! seqeralabs/wave#516 Sorry, didn't see it before. Yes if we can merge that first ☝🏻 then the docs will appear at docs.seqera.io. Then I think it's fine to merge this PR as the content will still be available and we can point there. So just a question of sequencing the merges correctly from my point of view. @pditommaso is it not better to do this before before the big Wave docs rewrite? I feel like this content should probably be included in the docs review for the new wave docs, rather than being tacked on afterwards... |
I'm not okay with deleting the Wave docs from Nextflow until there's an update and comprehensive documentation for Wave. My rationale: 1) moving pieces around just creates confusion, 2) the Wave docs are not blocked by this, and 3) there are many places, including Platform docs, that link the Wave docs in Nextflow. |
This content now also lives here: https://docs.seqera.io/wave/nextflow |
This PR shifts the Wave-specific guides over to the Wave repo and the Wave documentation site at: https://docs.seqera.io/wave