-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Batch validates the region before checking available VMs #5108
Draft
adamrtalbot
wants to merge
6
commits into
nextflow-io:master
Choose a base branch
from
adamrtalbot:throw_error_if_azure_batch_region_invalid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Azure Batch validates the region before checking available VMs #5108
adamrtalbot
wants to merge
6
commits into
nextflow-io:master
from
adamrtalbot:throw_error_if_azure_batch_region_invalid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This allows users to manually configure a region not available in Nextflow's list of Azure regions Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Moving to draft because lacks of tests |
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Good point because I missed something: bd60be3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Azure region was invalid (i.e. useast vs eastus) Nextflow would still check for regions. This PR checks for the existence of a region before checking for available VMs.
Additions:
TODO:
- Confirm this will work with an unlisted region, allowing users to manually configure a pool in a region if the Nextflow set of regions is out of date.I've confirmed this works with an unlisted region by deleting the
eastus
entry demonstrating that Nextflow raises a warning into the console: