Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Batch validates the region before checking available VMs #5108

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jul 3, 2024

If the Azure region was invalid (i.e. useast vs eastus) Nextflow would still check for regions. This PR checks for the existence of a region before checking for available VMs.

Additions:

  • Nextflow checks for a valid region before checking the available VMs.
  • This adds some very verbose logging which helps in debugging but might be too much.

TODO:
- Confirm this will work with an unlisted region, allowing users to manually configure a pool in a region if the Nextflow set of regions is out of date.
I've confirmed this works with an unlisted region by deleting the eastus entry demonstrating that Nextflow raises a warning into the console:

N E X T F L O W  ~  version 24.05.0-edge
Launching `https://github.com/nextflow-io/hello` [cheeky_hugle] DSL2 - revision: 7588c46ffe [master]
WARN: [AZURE BATCH] No location called eastus found! Please confirm it exists and the name is correct!
[fb/b8674b] Submitted process > sayHello (3)
[e1/275573] Submitted process > sayHello (1)
[5f/7bf8d5] Submitted process > sayHello (4)
[ad/1f8280] Submitted process > sayHello (2)
Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 4f59247
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67291f7858bd0e0008050f53
This allows users to manually configure a region not available in Nextflow's list of Azure regions

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot adamrtalbot self-assigned this Jul 8, 2024
@adamrtalbot adamrtalbot marked this pull request as ready for review July 8, 2024 10:30
@pditommaso pditommaso marked this pull request as draft July 8, 2024 13:48
@pditommaso
Copy link
Member

Moving to draft because lacks of tests

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot
Copy link
Collaborator Author

Moving to draft because lacks of tests

Good point because I missed something: bd60be3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants